-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added return_esmpy_regrid_operator to regrids and regridc #768
Added return_esmpy_regrid_operator to regrids and regridc #768
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Matt - looks good - thanks for the quick turn around!
I've made a few style suggestions.
Also we need {{return_esmpy_regrid_operator: bool, optional}}
to be fleshed out in cf/docstring/docstring.py
, after this line would be a good spot - hopefully the formatting is clear enough ...
And we need a new test method in cf/test/test_regrid.py
- just one that sets return_esmpy_regrid_operator=True
in both regrids
and regridc
, and checks the type (self.assertIsInstance
) of the returned object should suffice.
There's still time :)
Co-authored-by: David Hassell <davidhassell@users.noreply.github.com>
Co-authored-by: David Hassell <davidhassell@users.noreply.github.com>
How's this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done, Matt - thanks. I took it upon myself to do a bit of tidying, and shall merge it. You made it in to 3.16.2!
Fixes #766
Added return_esmpy_regrid_operator kwargs to field/regrids and field/regridc, so that users wanting to make use of the functionality offered by it can do so via regrids and regridc, without having to call the regrid worker function directly.
This is possibly my 2nd ever PR, so if I've done something stupid, please forgive me... xD
For example, see #767