Issue3575 2 - Use DataMgrUtils instead of CE #3607
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@StasJ, I looked into using RenderParams to query a random 3D variable but there does not seem to be a way to do this. The RenderParams gets instantiated with a dimensionality, and has no evident way to query variables outside of their given dimension. The only path forward I found was to use DataMgrUtils, shown here.
Also, the CE method used in PR #3584 does in fact find the domain extents by taking the union of all variables in the dataset. Not taking the union of the extents could break the PRegionSelector if we don't land on a variable that encloses the entire domain, which could happen. WRF can contain soil and fire grids that lie outside or within the meteorological grids that we typically deal with.
Feel free to pick whichever solution you like.