stb_vorbis: Fixed memory leak due to incorrect fix in nothings#1558. …

…Thanks to sezero: nothings#1557 (comment)
NBickford-NV · Feb 17, 2024 · f3869f8 · f3869f8
1 parent 89311cf
commit f3869f8
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/stb_vorbis.c b/stb_vorbis.c
@@ -3694,15 +3694,18 @@ static int start_decoder(vorb *f)
          return error(f, VORBIS_outofmem);
       }
       f->comment_list = (char**) setup_malloc(f, sizeof(char*) * (f->comment_list_length));
-      if (f->comment_list == NULL)                  return error(f, VORBIS_outofmem);
+      if (f->comment_list == NULL)
+      {
+         f->comment_list_length = 0;
+         return error(f, VORBIS_outofmem);
+      }
       memset(f->comment_list, 0, sizeof(char*) * f->comment_list_length);
    }
 
    for(i=0; i < f->comment_list_length; ++i) {
       len = get32_packet(f);
       f->comment_list[i] = (INT_MAX == len) ? NULL : (char*)setup_malloc(f, sizeof(char) * (len+1));
       if (f->comment_list[i] == NULL) {
-         f->comment_list_length = 0;
          return error(f, VORBIS_outofmem);
       }