Added onLoadStart & onLoadComplete callbacks #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkjohnson
reviewed
Jan 7, 2024
| if ( this.onLoadComplete ) { | ||
|
|
||
| this.onLoadComplete( ); | ||
| this.loading = false; |
There was a problem hiding this comment.
this.loading should be set to false regardless of whether onLoadComplete is set.
| @@ -675,6 +676,29 @@ export class TilesRenderer extends TilesRendererBase { | |||
| cached.scene = scene; | |||
| cached.metadata = metadata; | |||
|
|
|||
| if ( ! this.loading && this.parseQueue.items.length > 0 ) { | |||
There was a problem hiding this comment.
I think we should check this.parseQueue.items.length > 0 || this.downloadQueue.items.length > 0
|
|
||
| } | ||
|
|
||
| if ( this.loading && this.parseQueue.items.length === 0 && this.downloadQueue.items.length === this.parseQueue.items.length ) { |
There was a problem hiding this comment.
Why not check if this.downloadQueue.items.length === 0?
gkjohnson
reviewed
Jan 7, 2024
Comment on lines
+679
to
+688
| if ( ! this.loading && this.parseQueue.items.length > 0 ) { | ||
|
|
||
| if ( this.onLoadStart ) { | ||
|
|
||
| this.onLoadStart( ); | ||
|
|
||
| } | ||
| this.loading = true; | ||
|
|
||
| } |
There was a problem hiding this comment.
It occurs to me that this will not trigger if we're in a case where only one tile has downloaded - because this condition will be checked only once a file has been fully parsed. Perhaps this "onStart" condition should go at the end of the update function, instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds the callback
onLoadStart&onLoadCompletefor all loading starts and ends.#389
How to test:
I used mars.js example for the test and assigned
onLoadStart&onLoadCompletecallbacks to the tiles.