New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bridge] add get token payload for dev inspect #17563
[bridge] add get token payload for dev inspect #17563
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you may have some merging issue here, we'll see...
source_chain_id: u8, | ||
seq_number: u64, | ||
) -> BridgeResult<Option<ParsedTokenTransferMessage>> { | ||
let now = std::time::Instant::now(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is this used for?
@@ -657,6 +689,15 @@ module bridge::bridge { | |||
bridge.load_inner() | |||
} | |||
|
|||
#[test_only] | |||
public fun test_get_token_transfer_action_status( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not think we need the public
on test only function but fine either way
} | ||
|
||
// Convert BridgeMessage to ParsedTokenTransferMessage | ||
public fun to_parsed_token_transfer_message(message: &BridgeMessage): ParsedTokenTransferMessage { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
public
? it may very well be fine and harmless no matter what but figured I'd ask
Description
ParsedTokenTransferMessage
and functionget_parsed_token_transfer_message
to get parsed token transfer data given chain id and seq numget_token_transfer_action_status
privateTokenPayload
toTokenTransferPayload
get_token_transfer_xyz
and extract common logic todev_inspect_bridge
Test plan
existing tests and new tests added in this PR
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.