Add Bn254 GroupElement implementations
#763
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonas-lj
commented
Apr 9, 2024
|
|
||
| impl ToFromByteArray<SCALAR_LENGTH> for Scalar { | ||
| fn from_byte_array(bytes: &[u8; SCALAR_LENGTH]) -> Result<Self, FastCryptoError> { | ||
| // Note that arkworks uses little-endian byte order for serialization here. |
There was a problem hiding this comment.
The other groups uses big-endian so perhaps we should also do it here also, but the groth16 api expects little-endian representations, so it's not entirely consistent. Any opinions on this @benr-ml?
jonas-lj
force-pushed
the
jonas/bn254_group
branch
from
a21c1a2
to
710aa7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.