Change PropertyExpression generics to match SkriptLang #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mwexim
reviewed
Oct 31, 2023
Comment on lines
-32
to
+33
| "~objects", | ||
| "[1:recursive] (amount|number|size)" | ||
| "[1:recursive] (amount|number|size)", | ||
| "~objects" |
There was a problem hiding this comment.
I agree that the order of the generics is confusing and can easily be changed, but I don't understand why you would change the register methods as well, since they follow the general principle that requires the actual 'patterns' as the last argument.
There was a problem hiding this comment.
property expressions are mostly used like property of %objects% so that's why Skript has always been the property first than the object types.
There was a problem hiding this comment.
I understand. I won't be merging these changes, but feel free, like you said, to make use your own implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change PropertyExpression generics to match SkriptLang.
This drives me crazy when working with the skript-parser. In my opinion, it should match Skript's generic order like reading a book. Left to right. The left element gets the property return of the right element.
This is a big breaking change unfortunately.
I'll keep this updated as I will be cherry-picking this pull for my projects.