CloseWindow is now called when the Window is actually closed #4852
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
This is a bug fix.
When a window is closed by calling "window.close()" the Closing event isn't called. This even is only called when the Cross in the window is clicked. As a result, the CloseWindow function wasn't called and the ViewModel wasn't disposed.
🆕 What is the new behavior (if this is a feature change)?
By calling CloseWindow in the Closed event, when the CloseWindow function is called again and the ViewModel is disposed.
This is needed when you for example, want to show a popup to ask the user if they actually want to close, but you have to do this asynchrously.
💥 Does this PR introduce a breaking change?
No
🐛 Recommendations for testing
Nothing special.
📝 Links to relevant issues/docs
🤔 Checklist before submitting