Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACF Command rework - Done! #210

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

ACF Command rework - Done! #210

wants to merge 20 commits into from

Conversation

benwoo1110
Copy link
Member

@benwoo1110 benwoo1110 commented Dec 23, 2020 •
edited

This PR reworks Multiverse-NetherPortals commands to complement the changes from Multiverse/Multiverse-Core#2514.

Command Changes:

  • Instead of /mvnp show <nether|end>, it is now ``/mvnp list <nether|end>`. This is to make it more consistent across all MV modules.
  • Add a /mvnp listall [filter] [page] to show all link, with prefix to show what link type it is.
  • image

API Changes:

  • Add boolean result return of removeWorldLink method.
  • Boolean result for addWorldLink returns result of saveMVNPConfig method.

Other changes:

You can get the test builds at https://www.benergy10.dev/

@benwoo1110
Prepare netherportals for ACF intergration.
44ee6c7
@benwoo1110
Improve boolean return for linking methods.
d58f9b1
@benwoo1110
Add link and unlink commands.
6480149
@benwoo1110
Add lineTypes suggestion.
8575fa5
@benwoo1110
Add list command.
e823bab
@benwoo1110
Remove old command codes and cleanup plugin.yml.
454f971
@benwoo1110
Add listall command.
ff5c808
@benwoo1110
Update mv-core dependency.
9e629a4
@benwoo1110
Add root command.
a9f2bb0
@benwoo1110
Register root command.
2031cfa
@benwoo1110
Add usage command.
62649d0
@benwoo1110
Update mv-core dependency,
5dc1818
@benwoo1110
Use new registerSubModule method.
dd262f3
@benwoo1110
Use new showUsage method.
f788175
@benwoo1110
Fix permission node typo.
659deb9
@benwoo1110
Add command syntax and description.
9f3012d
@benwoo1110
Update PageDisplay to accomodate core changes.
643f77d
@benwoo1110
Add tab complete to usage commands.
c72caa6
@benwoo1110
Use string formatting in favour of concatenation and some cleanup.
d73d8c5
@benwoo1110
Update for new ContentDisplay api changes.
5799f65
@benwoo1110 benwoo1110 mentioned this pull request Feb 8, 2021
Open
@benwoo1110 benwoo1110 added PR: Enhancement Pull requests to implement a feature or improvement in code. PR: Needs Review By Dev Pull requests requires the approve of lead dev. labels Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR: Enhancement Pull requests to implement a feature or improvement in code. PR: Needs Review By Dev Pull requests requires the approve of lead dev.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@benwoo1110