Ben/mv5/modify command #3023
Closed
Ben/mv5/modify command #3023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/main/java/org/mvplugins/multiverse/core/commandtools/MVCommandContexts.java # src/main/java/org/mvplugins/multiverse/core/world/MultiverseWorld.java
| MultiverseWorld mvWorld = context.getContextValue(MultiverseWorld.class); | ||
| ConfigModifyType modifyType = context.getContextValue(ConfigModifyType.class); | ||
| String propertyName = context.getContextValue(String.class); | ||
| return mvWorld.suggestPropertyValues(modifyType, propertyName, context.getInput()); |
There was a problem hiding this comment.
Why is a world suggesting property values? This smells like MultiverseWorld is doing too much.
There was a problem hiding this comment.
Maybe parts of this class need to be exposed with a new interface with a getter on MultiverseWorld. I think this would help manage SRP a bit more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.