Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New module: ngs-bits #2231

Open
wants to merge 31 commits into
base: main
Choose a base branch
from
Open

New module: ngs-bits #2231

wants to merge 31 commits into from

Conversation

vladsavelyev
Copy link
Member

@vladsavelyev vladsavelyev commented Dec 14, 2023

Forking from @jakobmatthes's PR so I can merge with master and push some changes :)

Thank you so much @jakobmatthes for the contribution!

This is how the reports look like now:

Screenshot 2023-12-14 at 15 32 34

A few comments from me:

  • In MultiQC we try to avoid such wide tables - especially as the MappingQC one - as they lose in readability. I wonder if a lot columns can be marked as hidden by default?
  • One or two metric can be added into general stats
  • Can any data can be represented as a plot instead?
  • Read and base counts can be extended with the configurable prefixes/multipliers like described in this section: https://multiqc.info/docs/development/modules/#step-3---adding-to-the-general-statistics-table
    Example:
'title': f'{config.read_count_prefix} Reads',
'description': f'Number of reads ({config.read_count_desc})',
'modify': lambda x: x * config.read_count_multiplier,
  • Column names should be capitalized (insert size -> Insert size).
  • Nit picking: the % singes in the col names are redundant as they are used as the suffixes in the cells already.

Copy link
Contributor

github-actions bot commented Dec 14, 2023

🚀 Deployed on https://mqc-pr-2231--multiqc.netlify.app

@vladsavelyev vladsavelyev mentioned this pull request Dec 14, 2023
11 tasks
@vladsavelyev vladsavelyev changed the title New modiule: ngs-bits [2] New module: ngs-bits [2] Dec 15, 2023
@vladsavelyev
Copy link
Member Author

@multiqc-bot changelog

@multiqc-bot multiqc-bot changed the title New module: ngs-bits [2] New module: ngs-bits Dec 15, 2023
@vladsavelyev vladsavelyev added the waiting: changes Issue / PR is on hold, waiting for requested changes label Dec 15, 2023
@vladsavelyev
Copy link
Member Author

@multiqc-bot fix linting

@vladsavelyev
Copy link
Member Author

@multiqc-bot fix linting

@vladsavelyev vladsavelyev added this to the MultiQC v1.21 milestone Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: new waiting: changes Issue / PR is on hold, waiting for requested changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants