Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New module: metaDMG #2221

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

New module: metaDMG #2221

wants to merge 13 commits into from

Conversation

fgvieira
Copy link
Contributor

  • This comment contains a description of changes (with reason)
  • There is example tool output for tools in the https://github.com/ewels/MultiQC_TestData repository or attached to this PR
  • Code is tested and works locally (including with --strict flag)
  • docs/README.md is updated with link to below
  • docs/modulename.md is created
  • Everything that can be represented with a plot instead of a table is a plot
  • Report sections have a description and help text (with self.add_section)
  • There aren't any huge tables with > 6 columns (explain reasoning if so)
  • Each table column has a different colour scale to its neighbour, which relates to the data (eg. if high numbers are bad, they're red)
  • Module does not do any significant computational work

Add module to plot metaDMG results.

@@ -51,6 +51,7 @@
install_requires=[
"matplotlib>=2.1.1",
"networkx>=2.5.1",
"pandas",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to avoid including extra heavy dependencies as much as possible, and so far got away without pandas 😅 Wonder if it would be easy to use csv.DictReader here and operate on dicts?

multiqc/modules/metadmg/metadmg.py Show resolved Hide resolved
@vladsavelyev vladsavelyev changed the title Add module for metadmg New module: metaDMG Jan 24, 2024
@vladsavelyev vladsavelyev added the WIP Work in progress label Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: new WIP Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants