Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Refactor code for use within interactive environments #2036

Closed
wants to merge 12 commits into from

Conversation

vladsavelyev
Copy link
Member

Moving towards the interactive use:

  • Move the module report building logic out of __init__()
  • Make Report a normal class instead of a module singleton

@ewels
Copy link
Member

ewels commented Sep 15, 2023

Wondering if we can add in logic here to check if the build() def exists within a module. If so then run it the new way. However, if it's not there, then run the old way with __init__().

This way, the change is not a breaking change and we can push the refactoring before v2.0, essentially as progressive enhancement. We can also use it as an opportunity to log depreciation warnings so that folks know that the new syntax is ready and should be switched to.

Things like lint tests can abandon the old syntax completely, as all core MultiQC modules should be using the new syntax immediately.

@vladsavelyev vladsavelyev changed the title Refactor module and report Core: Refactor code for use within interactive environments Sep 15, 2023
@ewels
Copy link
Member

ewels commented May 13, 2024

Outdated, replacement now merged 🚀

@ewels ewels closed this May 13, 2024
@ewels ewels deleted the refactor-module branch May 13, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants