New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New module: ganon #1935
base: main
Are you sure you want to change the base?
New module: ganon #1935
Conversation
Example report: Also would be cool if @pirovc (author of ganon), would have a chance to have a look/leave comments if they have time/interest! |
Look good to me! Thanks. Later on statistics by taxonomic level can be included, but first I'd have to output them on the classify or report logs. |
@ewels @vladsavelyev anything else I need to do here for a review? |
We accept bribery in the form of biscuits 🍪 😋 We'll get to it soon, just working through the backlog 😊 |
@pirovc I realise this may be out of date now since ganon 2.0 came out - to your knowledge would any changes be required (or any additional info?) |
@vladsavelyev @ewels I'm sure you would check thoroughly anyway, but I've attempted to add the software version and satisfy the new linting rules, but this is my first module with those, so it would be good to check those a bit more closely when you get to this. |
Adds a module for ganon classify (note: the other sub commands produce similar-ish log files but are not informative)
CHANGELOG.md
has been updated--lint
flag)docs/README.md
is updated with link to belowdocs/modulename.md
is createdself.add_section
)