Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix not seeing java as 64 bit on M1 processors #5304

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix not seeing java as 64 bit on M1 processors #5304

wants to merge 1 commit into from

Conversation

bombcar
Copy link

@bombcar bombcar commented Dec 8, 2023 •
edited

On macOS with an M1 or M2 processor, it returns os.arch=aarch64 which is not recognized as a 64 bit architecture by the code.

This fixes that and the spurious warning goes away:

Checking Java version...
Java is version 21.0.1, using 32-bit architecture, from Eclipse Adoptium.


Your Java architecture is not matching your system architecture. You might want to install a 64bit Java version.

@runlevel5 runlevel5 mentioned this pull request Mar 21, 2024
Open
1 task
jeffro256
jeffro256 reviewed Apr 21, 2024
View reviewed changes
launcher/java/JavaChecker.cpp
@@ -129,7 +129,7 @@ void JavaChecker::finished(int exitcode, QProcess::ExitStatus status)
auto os_arch = results["os.arch"];
auto java_version = results["java.version"];
auto java_vendor = results["java.vendor"];
bool is_64 = os_arch == "x86_64" || os_arch == "amd64";
bool is_64 = os_arch == "x86_64" || os_arch == "amd64" || os_arch == "aarch64";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
bool is_64 = os_arch == "x86_64" || os_arch == "amd64" || os_arch == "aarch64";
const bool is_64 = os_arch.find("64") != std::string::npos;

@The-Only-E
Copy link

On macOS with an M1 or M2 processor, it returns os.arch=aarch64 which is not recognized as a 64 bit architecture by the code.

This fixes that and the spurious warning goes away:

Checking Java version...
Java is version 21.0.1, using 32-bit architecture, from Eclipse Adoptium.


Your Java architecture is not matching your system architecture. You might want to install a 64bit Java version.

I got this on Windows 11 running on a Raspberry Pi, so it's all java versions for ARM, except 8 for some reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffro256 jeffro256 jeffro256 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bombcar @The-Only-E @jeffro256