NOISSUE disable google analytics for now

MultiMC · Sep 2, 2023 · 12617ec · 12617ec
1 parent fb13f11
commit 12617ec
Showing 1 changed file with 9 additions and 9 deletions.
diff --git a/launcher/Application.cpp b/launcher/Application.cpp
@@ -730,8 +730,9 @@ Application::Application(int &argc, char **argv) : QApplication(argc, argv)
         qDebug() << "<> Application theme set.";
     }
 
+    // TODO: rework analytics to not use google
     // Initialize analytics
-    initializeAnalytics();
+    // initializeAnalytics();
 
     if(createSetupWizard())
     {
@@ -821,18 +822,17 @@ bool Application::createSetupWizard()
         }
         return false;
     }();
-    bool analyticsRequired = [&]()
-    {
-        if(BuildConfig.ANALYTICS_ID.isEmpty())
-        {
+    bool analyticsRequired = [&]() {
+        if(!m_analytics) {
             return false;
         }
-        if (!settings()->get("Analytics").toBool())
-        {
+        if(BuildConfig.ANALYTICS_ID.isEmpty()) {
             return false;
         }
-        if (settings()->get("AnalyticsSeen").toInt() < analytics()->version())
-        {
+        if (!settings()->get("Analytics").toBool()) {
+            return false;
+        }
+        if (settings()->get("AnalyticsSeen").toInt() < analytics()->version()) {
             return true;
         }
         return false;