Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infrastructure: Update text for translation in Crowdin #7202

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

mudlet-machine-account
Copy link
Contributor

@mudlet-machine-account mudlet-machine-account commented Apr 12, 2024

Brief overview of PR changes/additions

👑 An automated PR to make new text available for translation in Crowdin from refs/heads/development (255c548).

Motivation for adding to Mudlet

So translators can translate the new text before the upcoming release.

@Kebap
Copy link
Contributor

Kebap commented Apr 12, 2024

This will mostly just add two new texts for translation:

  • in GMCPAuthenticator
    • [ WARN ] - Could not log in to the game, is the login information correct? in line 96
  • [ WARN ] - Could not log in to the game: %1 in line 98

Not sure why they are different. Could be the same.
No explanation is given what %1 will contain. Maybe the name of the game?

<name>GMCPAuthenticator</name>
    <message>
        <location filename="../src/GMCPAuthenticator.cpp" line="96"/>
        <source>[ WARN ]  - Could not log in to the game, is the login information correct?</source>
        <translation type="unfinished"></translation>
    </message>
    <message>
        <location filename="../src/GMCPAuthenticator.cpp" line="98"/>
        <source>[ WARN ]  - Could not log in to the game: %1</source>
        <translation type="unfinished"></translation>
    </message>
</context>

@mpconley
Copy link
Contributor

There could be many reasons plugged in that %1, failed authentication, banned user, etc.

@Kebap
Copy link
Contributor

Kebap commented Apr 12, 2024

Oh, it's the reason for failure, and not the game information at all. See that is why it is a good practice to add a comment for translators which explain what kind of content each variable like %1 will contain in the end. Sorry I did not spot this when the actual PR was discussed but only now the texts are prepared for translation.

@vadi2
Copy link
Member

vadi2 commented May 20, 2024

/create links

@add-deployment-links
Copy link

add-deployment-links bot commented May 20, 2024

Hey there! Thanks for helping Mudlet improve. 🌟

Test versions

You can directly test the changes here:

No need to install anything - just unzip and run.
Let us know if it works well, and if it doesn't, please give details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants