Fix: remove spaces from reply to MXP version tag.

[eowmob]

Brief overview of PR changes/additions

Removes spaces from the version string returned by MXP to avoid parsing issues in the mud. Also, like other MXP clients, mudlet will now report the version nummer without prefixing the client name (which is reported in a separate field).

Motivation for adding to Mudlet

Improve MXP compatibility

Other info (issues closed, discussion etc)

This is meant as a fix to issue #7140 which popped up in recent PTB versions when the format of the internal version string was changed.

[add-deployment-links]

Hey there! Thanks for helping Mudlet improve. 🌟

Test versions

You can directly test the changes here:

• linux: https://make.mudlet.org/snapshots/336fe4/Mudlet-4.17.2-testing-pr7144-7519ee7c-linux-x64.AppImage.tar
• osx: https://make.mudlet.org/snapshots/520817/Mudlet-4.17.2-testing-pr7144-7519ee7c.dmg
• windows: https://make.mudlet.org/snapshots/2958dc/Mudlet-4.17.2-testing-pr7144-7519ee7c-windows.zip

No need to install anything - just unzip and run.
Let us know if it works well, and if it doesn't, please give details.

[vadi2]

Thanks for throwing a PR together. Could you also test #7138 ?

[eowmob]

Could you also test #7138 ?

Sure, I had already resynched my PR to the change of the development tree, so the test versions above contain the fix to both #7138 and my fix to #7140 (they really do, though the bot msg is shown before my merge entry, but check the build hash) . My PR and #7138 address somewhat different issues: I did not notice the GMCP issue (sorry), I noticed MXP parsing (in the mud) has issues when the version number was now prefixed with "mudlet " rather than "mudlet-".

As I already resynched or rebased my PR to the current development, I can say both fixes are compatible and deal with separate issues (note I did a bunch of recompiles, test version downloads etc. to check my fix and #7138 fix the resp. MXP / GMCP issue alone, nothing more). I was wondering though, why the trailing \n in the version string did not manifest in MXP.

After some gdb debugging I'm confident this boils down to ctelnet.cpp:607 bool cTelnet::sendData() which probably removes the additional \n with data.remove(QChar::LineFeed); in line 609 . So the \n at the end of the version string in the reply to <VERSION> never makes it to the mud.