add: automate uploading of windows release binaries #7106
Conversation
|
Hey there! Thanks for helping Mudlet improve. 🌟 Test versionsYou can directly test the changes here:
No need to install anything - just unzip and run. |
|
@vadi2 could you please check this PR once? |
| @@ -134,52 +134,54 @@ if ("$Env:APPVEYOR_REPO_TAG" -eq "false" -and -Not $Script:PublicTestBuild) { | |||
| $DEPLOY_URL = $DEPLOY_URL.Trim() | |||
| echo "Deployed Mudlet to '$DEPLOY_URL'" | |||
| } else { | |||
| # disabled temporarily as ssh key is unavailable | |||
| $sshKeyPath = "$Env:APPVEYOR_BUILD_FOLDER\CI\mudlet-deploy-key-windows" | |||
| ssh-keygen -t rsa -b 2048 -f $sshKeyPath -N ${Env:DEPLOY_KEY_PASS} | |||
There was a problem hiding this comment.
How would authentication against the mudlet.org server work exactly when it generates a new key on the spot?
There was a problem hiding this comment.
Yeah - there should already be a key at that location for which the password is available to the Core Devs - so I think theses 3 new lines need to be removed from the PR...
There was a problem hiding this comment.
👎 As far as I see it, the proposer has merely uncommented code that we had already in place (but disabled because it {no longer?} worked) and added a bogus new key generation. So all-in-all I am not sure that this represents any original work - or any improvement...
This PR adds the functionality of automating the upload of windows release binaries.
/fix #5865
/claim #5865