Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infra: automatic release tagging #7099

Open
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

ibishal
Copy link

@ibishal ibishal commented Jan 20, 2024

closes #5863
/claim #5863

@ibishal ibishal requested a review from a team as a code owner January 20, 2024 19:49
@add-deployment-links
Copy link

add-deployment-links bot commented Jan 20, 2024

Hey there! Thanks for helping Mudlet improve. 🌟

Test versions

You can directly test the changes here:

No need to install anything - just unzip and run.
Let us know if it works well, and if it doesn't, please give details.

@vadi2
Copy link
Member

vadi2 commented Jan 21, 2024

Hi! Thanks a lot for this PR. I should have been more clear in the original issue - the file update and tagging should automatically happen off a new Github release (example). The release tag would be the new version that needs to go into mudlet.pro and CMakeLists.txt, and that is what binaries should be built with.

Could you update the PR for that?

@ibishal
Copy link
Author

ibishal commented Jan 21, 2024

Hi! Thanks a lot for this PR. I should have been more clear in the original issue - the file update and tagging should automatically happen off a new Github release (example). The release tag would be the new version that needs to go into mudlet.pro and CMakeLists.txt, and that is what binaries should be built with.

Could you update the PR for that?

@vadi2 can you check the workflow ig it solve this issue

@vadi2
Copy link
Member

vadi2 commented Jan 27, 2024

Thanks for submitting a PR for this :) we've realised that we need to have a more comprehensive approach to this, so we'll put the automation bounties on hold while we work that out.

Here is a small thanks in the meantime for your efforts!

/tip $10

Copy link

algora-pbc bot commented Jan 27, 2024

Copy link

algora-pbc bot commented Jan 27, 2024

🎉🎈 @ibishal has been awarded $10! 🎈🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automate release tagging in Git
2 participants