Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scrollbar does not move with mousewheel/pg scrolling #612

Closed
vadi2 opened this issue Mar 31, 2017 · 7 comments · Fixed by #4085
Closed

Scrollbar does not move with mousewheel/pg scrolling #612

vadi2 opened this issue Mar 31, 2017 · 7 comments · Fixed by #4085
Labels
help wanted wishlist

Comments

@vadi2
Copy link
Member

vadi2 commented Mar 31, 2017

When you use the any non-scrollbar method to scroll, the scrollbar does not automatically move to adjust it's position.

Launchpad Details: #LP525080 Vadim Peretokin - 2010-02-20 23:09:45 +0000
@vadi2 vadi2 added the wishlist label Mar 31, 2017
@vadi2
Copy link
Member Author

vadi2 commented Jun 3, 2017

This is still an issue and is up there with the pet peeves people have with Mudlet.

@vadi2
Copy link
Member Author

vadi2 commented Nov 30, 2017

Steps to reproduce:

  1. open mudlet, connect to a game
  2. get some text in the scrollbar buffer
  3. avoid using the scrollbar to scroll - ie use the mousewheel or the trackpad
  4. observe scrollbar does not properly follow your scrolling

@Kebap
Copy link
Contributor

Kebap commented May 18, 2018

Confirmed in Mudlet 3.9, please fix, this makes Mudlet seem broken

@Kebap Kebap added the Hacktoberfest Code & win a T-shirt :) label Oct 1, 2018
@Kebap Kebap removed the Hacktoberfest Code & win a T-shirt :) label Nov 5, 2018
@CriusMacOldenly
Copy link
Contributor

Also, if you scroll with your mouse, or keyboard, or any non scrollbar method, if you then click on the scrollbar afterwards, the scrollbar moved the view location to the scrollbar location.
IE: It ignores any movements not done by the scrollbar.

@CriusMacOldenly
Copy link
Contributor

CriusMacOldenly commented Oct 21, 2019 •
edited

I have issued a fix for this problem in #3186 .
The entire changes for this fix are the differences between the original text selection patch, and patch 1.
If you don't want the #612 fix, don't use patch 1. If you do want the #612 fix, you can merge it in without the text selection fix which is the original patch. I'm certain the change is small enough that you can see the changes between the text selection fix and the scrollbar fix.

@Kebap Kebap mentioned this issue Oct 21, 2019
Closed
This was referenced Oct 23, 2019
Merged
Closed
@vadi2 vadi2 closed this as completed in 1436cfc Nov 4, 2019
@CriusMacOldenly
Copy link
Contributor

Wait! I removed all the code from text selection, and placed it in a separate branch for #3198 . This shouldn't be closed since it isn't handled by the text selection change at all!

@vadi2 vadi2 reopened this Nov 4, 2019
dicene pushed a commit to dicene/Mudlet that referenced this issue Feb 19, 2020
@CriusMacOldenly @dicene
Rewritten text selection (Mudlet#3166)
2e5c4f0 
* Improved text selection. Unhighlighting ctrl selects still broken.

* Removed the commented code.

* Removed the commented out code.

* Uploaded to wrong place.

* Uploaded to wrong place.

* Re-save with Unix line endings

* Same for the header

* Commented out more code to fix all known text selection and highlighting problems.

* This fixes Mudlet#612 .

* Altered unhighlight() y1 declaration and assignment as requested. Also deleted 6 lines which were commented out.

* Removed all the scrollbar changes for issue Mudlet#612. This now only handles text selection, and scroll bar changes are in a separate branch.

* Fixed drawing highlight box for double clicking a word.

* Altered ctrl click to select line on single ctrl click (Previously you needed to move the mouse to select the line(s).

* Unix line endings again

* Raise code to formatting standard

(use the clang-format tool with the .clang-format file at the root of the repository for this)

* Fixed ctrl-drag selection. Ensured ctrl-click selection worked too.

* Unix line endings
@Kebap Kebap mentioned this issue Jun 25, 2020
Closed
@Kebap
Copy link
Contributor

Kebap commented Jun 25, 2020

Linked issue has a nice gif to see action of this happening in Mudlet 4.9

@Edru2 Edru2 mentioned this issue Sep 25, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted wishlist
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Horizontal scrollbars for all consoles + scrollbar fixes Edru2/Mudlet
3 participants
@vadi2 @Kebap @CriusMacOldenly