Standardise the use of Hidden and HiddenChanged
#8952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
breaking change
bug
|
I think this is one of the rare cases where |
This was referenced May 11, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #8952 +/- ##
==========================================
+ Coverage 89.82% 90.49% +0.66%
==========================================
Files 412 419 +7
Lines 11878 12192 +314
Branches 2364 2380 +16
==========================================
+ Hits 10670 11033 +363
+ Misses 681 627 -54
- Partials 527 532 +5 ☔ View full report in Codecov by Sentry. |
This was referenced May 11, 2024
Don't necessarily disagree but Visible=false would be the default, right? |
danielchalmers
approved these changes
May 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MudBlazor currently uses the
IsHiddenandIsHiddenChangedproperties. This PR aims to standardise the use ofHiddenandHiddenChangedto align with other boolean properties in the library.Description
If this PR is approved, the v7 migration guide must also be updated, as this makes a breaking change:
MudHidden: replace
IsHiddenwithHiddenMudHidden: replace
IsHiddenChangedwithHiddenChangedLinked issues:
Negative property names should be discouraged #6131
v7.0.0 Migration Guide #8447
Standardise the use of
IsEnabledandEnabled#8764Standardise the use of
ItemDisabled#8887Standardise the use of
Checked,CheckedChangedandCheckable#8825Standardise the use of
Visible#8832Standardise the use of
SelectedandSelectedChanged#8886Standardise the use of
Expanded,Expandable,IsExpandedandIsExpandable#8718Standardise the use of
Active#8888Standardise the use of
OpenandOpenChanged#8891Standardise the use of
Editable#8892Standardise the use of
HiddenandHiddenChanged#8952How Has This Been Tested?
unit
Type of Changes
Checklist
dev).