Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: fix slider tests failing on certain cultures #8949

Merged
merged 2 commits into from May 12, 2024

Conversation

henon
Copy link
Collaborator

@henon henon commented May 11, 2024

Two slider tests failed on my locale. Made sure they work everywhere the same.

Copy link

codecov bot commented May 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.46%. Comparing base (28bc599) to head (da374a9).
Report is 186 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #8949      +/-   ##
==========================================
+ Coverage   89.82%   90.46%   +0.63%     
==========================================
  Files         412      419       +7     
  Lines       11878    12197     +319     
  Branches     2364     2381      +17     
==========================================
+ Hits        10670    11034     +364     
+ Misses        681      628      -53     
- Partials      527      535       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@henon henon requested a review from ScarletKuro May 11, 2024 14:13
@ScarletKuro
Copy link
Member

Should we maybe just set [SetCulture("en-US")] on the tests to not rely on the converters that might be reworked in future?

@henon
Copy link
Collaborator Author

henon commented May 12, 2024

I don't mind for the tests, will change.

But even if the converters are reworked they will do exactly this job, converting to and from string using a specified culture.

@ScarletKuro ScarletKuro merged commit 8465df5 into MudBlazor:dev May 12, 2024
4 checks passed
@henon henon deleted the slider-test-fix branch May 13, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants