Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MudCard: Fix content not filling remaining space #8933

Merged
merged 1 commit into from May 13, 2024

Conversation

danielchalmers
Copy link
Contributor

Description

Makes the card a flex display in order to configure the content to be the one that grows in the case where the card is taller than all the children combined. This is similar to #8743

How Has This Been Tested?

visually

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Before

image

After

image

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added bug Something does not work as intended/expected PR: needs review labels May 10, 2024
@danielchalmers danielchalmers requested a review from henon May 10, 2024 05:32
Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.48%. Comparing base (28bc599) to head (e33f0ad).
Report is 176 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #8933      +/-   ##
==========================================
+ Coverage   89.82%   90.48%   +0.65%     
==========================================
  Files         412      419       +7     
  Lines       11878    12189     +311     
  Branches     2364     2380      +16     
==========================================
+ Hits        10670    11029     +359     
+ Misses        681      628      -53     
- Partials      527      532       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielchalmers
Copy link
Contributor Author

Looks good @henon ?

@henon henon merged commit 8127191 into MudBlazor:dev May 13, 2024
5 checks passed
@henon henon mentioned this pull request May 13, 2024
@henon
Copy link
Collaborator

henon commented May 13, 2024

Thanks. Even though it can be considered to be just a bugfix I still added it to the migration guide to be safe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants