Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DatePicker: default OpenTo to Year when both FixDay and FixMonth are provided #8932

Merged
merged 3 commits into from May 18, 2024

Conversation

ZephyrZiggurat
Copy link
Contributor

@ZephyrZiggurat ZephyrZiggurat commented May 9, 2024

Description

Flipped the order of setting the default OpenTo in MudBaseDatePicker.OnPickerOpened. FixDay by itself was checked first and so combining FixDay and FixMonth was no longer considered.

This only occurs when the user does not explicitly set OpenTo when using the date picker.

How Has This Been Tested?

added Open_FixMonth_FixDay_CheckOpenTo and Open_FixDay_CheckOpenTo

Type of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (fix or improvement to the website or code docs)

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

@github-actions github-actions bot added bug Something does not work as intended/expected PR: needs review labels May 9, 2024
Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.48%. Comparing base (28bc599) to head (235e63b).
Report is 194 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #8932      +/-   ##
==========================================
+ Coverage   89.82%   90.48%   +0.65%     
==========================================
  Files         412      419       +7     
  Lines       11878    12211     +333     
  Branches     2364     2385      +21     
==========================================
+ Hits        10670    11049     +379     
+ Misses        681      627      -54     
- Partials      527      535       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ScarletKuro
Copy link
Member

Hi.

Thanks for the PR.
Please add a bUnit test for the scenario that you fixed.

@ZephyrZiggurat
Copy link
Contributor Author

Tests added!

@henon henon merged commit 7b46a62 into MudBlazor:dev May 18, 2024
4 checks passed
@henon
Copy link
Collaborator

henon commented May 18, 2024

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants