MudListItem: SecondaryText Feature

[mckaragoz]

Description

Added SecondaryText parameter to MudListItem.

How Has This Been Tested?

Already using with MudListItemExtended.

20240508_143403.mp4

Type of Changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation (fix or improvement to the website or code docs)

Checklist

• The PR is submitted to the correct branch (dev).
• My code follows the code style of this project.
• I've added relevant tests.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.48%. Comparing base (28bc599) to head (418b754).
Report is 185 commits behind head on dev.

Additional details and impacted files

@@            Coverage Diff             @@
##              dev    #8921      +/-   ##
==========================================
+ Coverage   89.82%   90.48%   +0.65%     
==========================================
  Files         412      419       +7     
  Lines       11878    12197     +319     
  Branches     2364     2381      +17     
==========================================
+ Hits        10670    11036     +366     
+ Misses        681      627      -54     
- Partials      527      534       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Yomodo]

I normally use mt-n or pt-n instead of br/>

[mckaragoz]

It's not about margin or padding. Need to be sure secondary text placed on new line. In some situations text and secondary text show in one line. And there is no guarantee that MudText never be changed.

[mckaragoz]

@henon test done.

[henon]

Thanks!

[Alerinos]

@henon I was reminded that mud is missing a basic implementation of <ul> <li>.
Taking this opportunity, what do you guys think about introducing a simple implementation?

[henon]

@Alerinos I struggle to imagine how it should look like compared to MudList. Can you share examples from other toolkits that have what you mean?

[Alerinos]

@henon

I made such a thing, it is a simple list. I am missing such a component in MudBlazor.
You might want to make a new component called <MudSimpleList>?

[henon]

That is so simple that it is probably not worth adding this. Can't you just directly use <ul> and put <MudText> inside the <li> ?

[Alerinos]

@henon
You can manually do it but it spoils our look and doesn't fit with the rest.
Having the Mud component everything is nicely compatible with each other, if we want to change the look of the layout everything changes nicely. We should have as many components as possible

I'm just in migration, MudList requires T parameter, shouldn't we allow nullable?
Currently this is what my code looks like:

[henon]

I'm just in migration, MudList requires T parameter, shouldn't we allow nullable?

Nullable types are allowed, for instance int?.

[Alerinos]

@henon

I meant that MudList requires T, should be default value or nullable possible.

[henon]

I know, I would prefer that too, but Blazor doesn't allow it

[Alerinos]

@henon Can't we set a default T, or make it null?

    public partial class MudList<T> : MudComponentBase, IDisposable : this(default(T))

Alternatively, it is possible to do “overloading” and create two classes, one with T and one without. In this case, we will handle everything.

[henon]

@henon Can't we set a default T, or make it null?

    public partial class MudList<T> : MudComponentBase, IDisposable : this(default(T))

Is this even legal C# ?

Alternatively, it is possible to do “overloading” and create two classes, one with T and one without. In this case, we will handle everything.

We tried that too, doesn't work. This is a technical limitation of Blazor that only Microsoft can fix.