New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MudGrid: Refactor and normalize spacing system #8910
Conversation
Need help making sure I fixed those issues correctly. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #8910 +/- ##
==========================================
+ Coverage 89.82% 90.46% +0.63%
==========================================
Files 412 419 +7
Lines 11878 12210 +332
Branches 2364 2385 +21
==========================================
+ Hits 10670 11046 +376
+ Misses 681 628 -53
- Partials 527 536 +9 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@ncigula @aabney-Tamus @fabianschurz This PR should fix your issues. If you want to confirm, please do so. |
@danielchalmers What if we allow up to 20 as the max value of spacings? Because if you used What shall we write in the migration guide? How to calculate from old spacing to new one? |
Yes, it looks like this should fix #4869 |
It uses the CSS The calculation is a little complex because the width, padding, and margin were changed before and now it's just gap. I would just tell people to revise it by eye. @henon |
@henon This should be ready to go - I've completely reworked the grid spacing system and it should be the best of both worlds now. In the Migration Guide it just needs to say "it's been scaled 2x so you need to double your current spacing". Very easy to switch over and fixes the original issues while keeping it close to the original design. |
The old grid used |
src/MudBlazor.Docs/Pages/Components/Grid/Examples/GridSpacingExample.razor
Outdated
Show resolved
Hide resolved
Yes; It was applying 4px to all sides. Now only top & left |
Thanks @danielchalmers Added this to the migration guide |
@henon Yes i believe it would with the changes in _grid.scss because the margin value would no longer be bigger then the value added on top the 100% width |
Description
6
, up from3
, because the step has been halvedThis does change the amount of spacing for current consumers but allows for finer control and aligns with library.
How Has This Been Tested?
visually
Type of Changes
Grid & Stack (Before & after)
Default spacing (Before & after)
Min spacing (Before & after)
Max spacing (Before & after)
Full component page in docs (Before & after)
video6.mp4
Checklist
dev
).