New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: MudColorPicker: Added XML Documentation for Public Members #8872
Docs: MudColorPicker: Added XML Documentation for Public Members #8872
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #8872 +/- ##
==========================================
+ Coverage 89.82% 90.48% +0.65%
==========================================
Files 412 419 +7
Lines 11878 12197 +319
Branches 2364 2381 +17
==========================================
+ Hits 10670 11036 +366
+ Misses 681 627 -54
- Partials 527 534 +7 ☔ View full report in Codecov by Sentry. |
I hope you're having a good weekend @henon @danielchalmers ! There are a couple of things to note in this PR:
As always, thanks for taking the time to review! |
Lightness is correct. |
I am no native speaker but somehow this construction with whether still bothers me: |
@henon The goal should be to keep it short to fit on the website so I think that's an improvement. Here's some ChatGPT magic to see what it could look like: Here are the changes I made to the documentation comments in your C# code to reflect the new style:
These changes make the documentation more concise and align with the new style you're aiming for, focusing on action rather than condition. To further streamline and improve your documentation, especially if you want it to be concise, consider these additional styles:
|
#8903 was started to support XML elements like |
Alrighty, I've rewritten all of the "Whether" boolean docs to use more active language. That was a great suggestion because it slimmed down the sentences while making them more readable. Ready to review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really great, love the changes. Hope you don't mind the number of notes - Most of it is subjective and is not necessarily better or worse but I wanted to get some more ideas going!
All good, @danielchalmers ! The extra scrutiny is smart at the start of this effort so we can all get a good standard to follow. That will make the next several docs PR's go smoothly! |
I'm going to sneak in one more commit to fix up |
Very nice, thanks a lot @jperson2000 |
Description
This update adds XML documentation for
MudColorPicker
and related classes:This update also removes prior documentation for the
RightToLeft
property in some components because it cannot be set via the Razor editor (and thus no documentation can be displayed).Then, XML documentation was added for the
MudRTLProvider
class.How Has This Been Tested?
This was tested by observing the example source code for
MudColorPicker
.Type of Changes
Checklist
dev
).