Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update _fab.scss #8645

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Update _fab.scss #8645

wants to merge 1 commit into from

Conversation

syntax-tm
Copy link

@syntax-tm syntax-tm commented Apr 11, 2024

Updated the mud-fab-extended classes width and height to match the one in the normal mud-fab class.

Description

Currently a FAB with a Label set, i.e. a mud-fab-extended, will not match the sizing of the standard, non-extended, FAB.

image

The height, min-width, and border-radius of an extended FAB should be equal to the standard FAB's height, width, and border-radius respectively.

How Has This Been Tested?

This is a visual change it's pretty straightforward. See below for screenshots.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Before:

image

After:

image

Checklist

  • The PR is submitted to the correct branch (dev).
  • My code follows the code style of this project.
  • I've added relevant tests.

Updated the mud-fab-extended classes width and height to match the one in the normal mud-fab class.
@github-actions github-actions bot added bug Something does not work as intended/expected PR: needs review labels Apr 11, 2024
Copy link

codecov bot commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.86%. Comparing base (28bc599) to head (daccba0).
Report is 20 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #8645      +/-   ##
==========================================
+ Coverage   89.82%   89.86%   +0.03%     
==========================================
  Files         412      414       +2     
  Lines       11878    11913      +35     
  Branches     2364     2364              
==========================================
+ Hits        10670    10706      +36     
+ Misses        681      676       -5     
- Partials      527      531       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@danielchalmers danielchalmers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and makes sense, but I don't use the FABs so I might not be the one to ask

@ScarletKuro
Copy link
Member

Probably requires feedback from @Garderoben

@henon
Copy link
Collaborator

henon commented Apr 13, 2024

I'll defer this decision to @Garderoben

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something does not work as intended/expected PR: needs review
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

4 participants