Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refacto(ocio): config overhaul #35

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from
Draft

refacto(ocio): config overhaul #35

wants to merge 14 commits into from

Conversation

MrLixm
Copy link
Owner

@MrLixm MrLixm commented Apr 21, 2024 •
edited

Bif refactoring of the config

Changelog

Added

  • Introduce config variants and an OCIO v2 variant of the config: same config as v1 but taking benefit of specific OCIO v2 feature. Benefits are:
    • remove allocation vars (OCIO GPU engine)
    • use proper clamp in AgX Log
  • BT.2020 colorspace, with linear transfer-function

Changed

  • Simplified family for "view" colorspaces
  • ! new colorspace naming convention:
    • we try to follow the convention {gamut name}-{transfer function}(-{whitepoint}) so Linear sRGB become sRGB-linear
    • introduce the concept of "Image colorspace". An output-refered colorspace that include image and display rendering with an optional look.

Chore

  • split the build script into multiple modules to make code maintenance/browsing easier
  • introduce the variant concept in build script
  • automatise the generation of <View> and their colorspaces (Image Colorspaces)

@MrLixm
refacto(ocio): pack config in variant subdir
599e7f8 
the plan is to have multiple config variants for users,
@MrLixm
refacto(ocio): add variants with OCIOv2 variant
d93d1d6
@MrLixm
refacto(.dev.ocio): define config path higher up
04c916f
@MrLixm
refacto(ocio): improve AgX Log clamp on OCIO v2
68d7917
@MrLixm
refacto(ocio): remove allocationVars on OCIOv2
6b3a431
@MrLixm
refacto(ocio): remove version from directory name
ab2a4a8
@MrLixm
fix(.dev.ocio): remove colorspace name set twice
43048f5
@MrLixm
feat(ocio): add "Linear BT.2020" colorspace
2b100b4
@MrLixm
feat(ocio): simplify the matrix transformations
cf48843
@MrLixm
refacto(ocio): improve Family for "view" colorspaces
0f18f46
@MrLixm
refacto(.dev.ocio): split code to own modules
1010832 
reduce the build script by splitting "utility" code to different modules
@MrLixm
refacto(ocio): reorganizing colorspaces; simplify EOTF
f6487ad
@MrLixm MrLixm added the enhancement New feature or request label Apr 21, 2024
@MrLixm MrLixm self-assigned this Apr 21, 2024
@MrLixm
!refacto(ocio): new logic to build "image colorspaces"
89267f2 
- this reduce code duplication.
- the initial need is that we want each `view` to have its own colorspaces defined, for software that don't expose `views` in export options.
   - this mean we need to build a matrix of display colorspaces x image renderings x looks
   - we call those colorspaces "image colorspaces" as they produce a viewable image.
- we also renamed other colorspaces to have a more consistent and subjectively better naming convention
@MrLixm
refacto(.dev.ocio): improve variables name
663fe77
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@MrLixm MrLixm

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@MrLixm