Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add android builds to CI #128

Open
wants to merge 1 commit into
base: release/v7.x
Choose a base branch
from

Conversation

BenjaminAmos
Copy link
Contributor

This is just a small change that updates the Jenkinsfile to use the Android build agent and enables building/publishing the gestalt-android library. I also fixed a compilation error in gestalt=android-testbed that had been previously overlooked when re-naming Component#copy to Component#copyFrom.

This should fix #127.

@keturn
Copy link
Member

keturn commented Nov 8, 2021

Is it okay for this android agent to also publish the libraries that Java apps will use, or do we need to build those in a separate environment?

@BenjaminAmos
Copy link
Contributor Author

The android agent is just a standard java agent with the android SDK pre-installed. I don't think that the android gradle plugin is used unless gradle is directly building an android project. I often leave the android local.properties file in when developing and testing and it hasn't adversely affected things before. I can put the standard java modules and android modules into seperate build steps like Destination Sol does though (see here), which would mean that only the android modules are published from an android-enabled build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants