-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEATURE: multishank capabilities #641
Comments
Version 4.0.4 should handle this now, I'll close this after getting feedback from people using it on their data. |
Hi @jacobpennington, Is it my impression, or does the sorting algorithm not generalize properly? Is KS treating the two groups per shank separately? If it helps, I've attached the "channel_positions.npy" output file (converted to .csv) and the original probe information obtained through probeinterface. |
@paolahydra Sorry, I don't understand the problem. Kilosort does not re-order channels, they're indexed in the order provided in the probe file. The |
@jacobpennington The problem is two-fold.
Thanks. |
re point 1: my bad, I found my problem. The actual probe file and the channel-position file do indeed show the same ordering. I am just left with q2... thanks! |
Re: q2, the ordering of the contacts does not matter, so that is not a
problem. The x,y positions are treated the same whether the contacts are
listed next to each other or far apart.
…On Tue, May 14, 2024, 1:36 AM Paola Patella ***@***.***> wrote:
re point 1: my bad, I found my problem. The actual probe file and the
channel-position file do indeed show the same ordering. I am just left with
q2... thanks!
—
Reply to this email directly, view it on GitHub
<#641 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIQ6WYDMHZEICL7GMTA5OXLZCHEJZAVCNFSM6AAAAABFJ4E7HKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBZGYYDENBSGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
I've heard back from several people that multi-shank sorting is working fine, so I'm going to close this one now. If anyone encounters more issues related to multi-shank recordings, please open a new issue. |
Feature you'd like to see:
Right now we are telling users to stack the shanks of probes vertically on top of each other, which seems to work pretty well (and it should). However, it would be better to explicitly treat the shanks as separate sets of data, to avoid any edge effects at the boundaries. There are multiple places where channels from different shanks could currently "interact" and we need the shanks to be treated separately in all those cases.
Additional Context
No response
The text was updated successfully, but these errors were encountered: