Validate Minimum Wine Version 8.0 for .NET 8 #8220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harry-cpp
reviewed
Mar 5, 2024
| # see https://github.com/MonoGame/MonoGame/issues/8103 | ||
| # wine --version will output 'wine-#.# (Ubuntu #.#.#)' | ||
| # grep to find only the 'wine-#' then use sed to remove the 'wine-' prefix | ||
| WINE_VERSION=$(wine --version 2>&1 | grep -oP 'wine-\d+' | sed 's/wine-//') |
There was a problem hiding this comment.
wine --version will output something like
wine-#.# (Ubuntu #.#.#)
grep is used to pattern match the wine-# string specifically from thr output, then sed to remove the wine- prefix which just leaves the major version number of wine detected.
Since it's an integer value and not the #.# floating point value, that makes the version check a simple if statement.
There was a problem hiding this comment.
sed does support regex, but I guess this is fine as well.
Modify comment to:
# wine 8 is the minimum requirement for dotnet 8
# wine --version will output "wine-#.# (Distro #.#.#)" or "wine-#.#"
The rest is not needed.
There was a problem hiding this comment.
@harry-cpp comment modified.
12 tasks
viniciusjarina
pushed a commit
to codefoco/MonoGame
that referenced
this pull request
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This updates the mgfxc_wine_setup.sh script to validate that at minimum Wine version 8.0 is installed.
References