Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding starter build tasks #10

Merged
merged 19 commits into from
Feb 27, 2024
Merged

Adding starter build tasks #10

merged 19 commits into from
Feb 27, 2024

Conversation

frgarc
Copy link
Contributor

@frgarc frgarc commented Feb 1, 2024

  • Adding common tasks for starter samples

rlandav
rlandav requested changes Feb 1, 2024
View reviewed changes
tools/core-build-tasks/src/tasks/cleanCollateral.ts Outdated Show resolved Hide resolved
tools/core-build-tasks/src/tasks/copy.ts Outdated Show resolved Hide resolved
tools/core-build-tasks/src/tasks/copy.ts Outdated Show resolved Hide resolved
tools/core-build-tasks/src/tasks/copy.ts Outdated Show resolved Hide resolved
tools/core-build-tasks/src/tasks/generateContentsJson.ts Outdated Show resolved Hide resolved
tools/core-build-tasks/src/tasks/helpers/getOrThrowFromProcess.ts Outdated Show resolved Hide resolved
@frgarc frgarc requested a review from rlandav February 6, 2024 21:10
rlandav
rlandav approved these changes Feb 20, 2024
View reviewed changes
Copy link
Collaborator

@rlandav rlandav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally minor feedback but a few things that could be moved from the samples into the core build tasks.

tools/core-build-tasks/src/tasks/bundle.ts Outdated Show resolved Hide resolved
tools/core-build-tasks/src/tasks/bundle.ts Outdated Show resolved Hide resolved
tools/core-build-tasks/src/tasks/cleanCollateral.ts Outdated Show resolved Hide resolved
tools/core-build-tasks/src/tasks/copy.ts Outdated Show resolved Hide resolved
tools/core-build-tasks/src/tasks/helpers/copyFiles.ts Outdated Show resolved Hide resolved
tools/core-build-tasks/src/tasks/index.ts Outdated Show resolved Hide resolved
@rlandav
Copy link
Collaborator

rlandav commented Feb 20, 2024

also, make sure to add change files!

@frgarc
Change files
f205abb
@frgarc
- Removing not needed tasks.
13baf50 
- General renames
- Adding change file
- Updating dependencies
@frgarc
- Nit at index file
00a345b
@frgarc frgarc requested a review from rlandav February 22, 2024 00:56
@frgarc frgarc marked this pull request as ready for review February 22, 2024 01:01
@frgarc
Copy link
Contributor Author

frgarc commented Feb 22, 2024

also, make sure to add change files!

Added change file

@frgarc frgarc requested a review from rlandav February 26, 2024 15:55
rlandav
rlandav requested changes Feb 26, 2024
View reviewed changes
Copy link
Collaborator

@rlandav rlandav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to not update the package.json versions manually, the change files will do that.

tools/eslint-config-minecraft-scripting/package.json Outdated Show resolved Hide resolved
tools/eslint-plugin-minecraft-linting/package.json Outdated Show resolved Hide resolved
@frgarc frgarc requested a review from rlandav February 26, 2024 21:02
rlandav
rlandav approved these changes Feb 26, 2024
View reviewed changes
Copy link
Collaborator

@rlandav rlandav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rlandav rlandav merged commit c1fb500 into main Feb 27, 2024
2 checks passed
@rlandav rlandav deleted the frgarc/starterTasks branch February 27, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlandav rlandav rlandav approved these changes

@JakeShirley JakeShirley Awaiting requested review from JakeShirley JakeShirley is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@frgarc @rlandav