Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate Web-View from UI Package #46

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Shahriyar13
Copy link

@Shahriyar13 Shahriyar13 commented Dec 7, 2023

Please review it, I am not sure about adding CocoaPods/Regular Framework dependency is because of WebView or not, If it's true, the documents should be change too.

Because of JavaFX usage in WebView module, and adding JavaFX and coroutines only because of WebView, I separated WebView to another package:

api("com.mohamedrejeb.calf:calf-ui-webview:0.3.0")

com.sun.javafx.application.PlatformImpl startup
WARNING: Unsupported JavaFX configuration: classes were loaded from 'unnamed module @82702de'
Exception in thread "JavaFX Application Thread @coroutine#1" java.lang.IllegalArgumentException: Not on Main thread, current thread is: Thread[#24,JavaFX Application Thread @coroutine#1,5,system]

@Shahriyar13
Copy link
Author

If you agree for next release:

Breaking Changes:

WebView removed from UI:

// For Adaptive WebView components
api("com.mohamedrejeb.calf:calf-ui-webview:0.3.0")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant