Added pseudo-element testing API

[willfarrell]

Added selectorSupported() from https://gist.github.com/paulirish/441842 w/ tests
Added pseudo-element reveal feature detect

[stucox]

Cool, thanks — especially for including a test.

Including this in its current state could well result in a bit of code bloat though — we already have functions which can do a lot of this; such that e.g. our detect for :checked is only a few lines long.

I'm wondering if we could refactor this to provide the same API (selectorSupported(...)), but make use of Modernizr.testStyles like that detect does?

We could also use Modernizr._prefixes to test all the prefixes automatically, so that your detect for ::reveal could simply be:

Modernizr.addTest('reveal', selectorSupported('::reveal'));

[willfarrell]

Thanks @stucox, I'll look into those functions and see what I can come up with.

[dotherightthing]

Hi,

Is selectorSupported part of Modernizr now? I have found a :checked test which uses it, but it is failing with selectorSupported is not defined.

Note that I am using a custom build of Modernizr (generated today) - is this a special option that I need to enable in my build?

Thanks,
Dan

[patrickkettner]

Hey @dotherightthing nosir, this hasn't been merged, so it is not a part of the test.

Was there something in particular you were looking for?

[dotherightthing]

Hi, just updated my question :)

Cheers
Dan

[patrickkettner]

Its not a part of modernizr. We already have a detect for :checked though, as @stucox mentions above.

[dotherightthing]

Hi @patrickkettner, thanks for the heads up. So do I need to copy the linked checked.js into my code, or is there some way to call this? On a side note I'm finding it quite difficult to navigate the plethora of options available in Modernizr ;-)

[patrickkettner]

:[
Really sorry about that, @dotherightthing. There has been a HUGE rewrite between the current version and this one. If you are wanting to live on the cutting edge, you can download the repo, edit lib/config-all.json to be the tests you want, then run grunt. That will build a version of modernizr with the tests you want.

If you just want to cut and paste the test, you should be able to copy this bit into a custom build of modernizr from the .com builder. Just change testStyles to Modernizr.testStyles, and createElement to document. createElement.

[dotherightthing]

Hey no worries, appreciate the great work you guys are doing! :) I'll copy and paste for now, and if it's not working I'll try the other option. Cheers.

[patrickkettner]

good luck!

[patrickkettner]

@willfarrell - were you still interested in getting this merged in?

[willfarrell]

Yeah I would, all my project have been using a custom version of moderizr for the better part of a year now. Would love to keep modernizr up to date with bower.

[patrickkettner]

Great to hear! do you need any guidance?

[patrickkettner]

ping @willfarrell

[willfarrell]

Sorry, works been crazy. Clearly I don't have time to address carry this over the finish line. If I have time in the future I'll submit a new PR. Anyone else that would like to take it forward, please do so.

[patrickkettner]

No problem at all, @willfarrell! Sorry if you felt pressured as all :[

I'll leave this open for now so we don't forget about it :D