indexeddbblob: Fix test not triggering, update metadata
#2608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `indexedbblob` test never triggers, even on platforms that support IndexedDB or blobs in IndexedDB databases. This is because in 164e757, `indexeddb` was changed to an async test, but `indexeddbblob` still assumes that `indexeddb` test is synchronous. Therefore, the `indexeddb` check is never true and `indexedbblob` never triggers. The `onsuccess` / `onerror` / exception handlers also assign the test result to a shared variable before calling `addTest()`, which results in the test result being always false as the variable will not be updated synchronously before `addTest()`. Let's: * wrap the `indexeddbblob` test in a `on('indexeddb.deletedatabase')` listener, so that it will trigger when `indexeddb` and `indexeddb.deletedatabase` pass * call `addTest()` in the `onsuccess` / `onerror` / exception handlers instead of assigning to a shared variable
* add `storage` tag * mark as async
|
Thx @Xenonym that sounds very reasonable. What do you think @patrickkettner sicne you wrote the original tests? |
|
Would you be so kind as to label this PR |
|
hey could you assign me this task and let me contribute? |
could you look for another issue. This PR is stale and not currently worked but still somebody else worked on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
indexeddbblob: Fix test never triggeringThe
indexedbblobtest never triggers, even on platforms that support IndexedDB or blobs in IndexedDB databases.This is because in 164e757,
indexeddbwas changed to an async test, butindexeddbblobstill assumes thatindexeddbtest is synchronous. Therefore, theindexeddbcheck is never true andindexedbblobnever triggers.The
onsuccess/onerror/ exception handlers also assign the test result to a shared variable before callingaddTest(), which results in the test result being always false as the variable will not be updated synchronously beforeaddTest().Let's:
indexeddbblobtest in aon('indexeddb.deletedatabase')listener, so that it will trigger whenindexeddbandindexeddb.deletedatabasepassaddTest()in theonsuccess/onerror/ exception handlers instead of assigning to a shared variableindexeddbblob: Add missing metadata properties
storagetagasync