Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure workers exists before terminating them #2302

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Ensure workers exists before terminating them #2302

wants to merge 2 commits into from

Conversation

simongareste
Copy link
Contributor

This should avoid the "undefined is not a function" error when terminating workers

@patrickkettner
Copy link
Member

@simongareste where did you see this error? If they are undefined they should not pass the current if since undefined is falsey

@rejas rejas added the feedback needed issue/pr has open question, reporter needs to answer label Oct 6, 2019
@rejas
Copy link
Member

rejas commented Oct 6, 2019

hi @simongareste is this still a thing? could you provide some more infos as requested by @patrickkettner ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@simongareste simongareste

Labels
feedback needed issue/pr has open question, reporter needs to answer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@simongareste @patrickkettner @rejas