fixes for problems inside iframes #2281
Conversation
|
hey @rozek! |
|
hi @rozek could you updare your PR against the latest master so we can check it out? |
|
Yes, I will do so...give me a few hours
… Am 11.07.2018 um 12:39 schrieb Veeck ***@***.***>:
hi @rozek <https://github.com/rozek> could you updare your PR against the latest master so we can check it out?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#2281 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAfbQrsyu_9VPXTsT1-dF1HpJjVUEudYks5uFdXIgaJpZM4RkXwR>.
|
|
Awesome. Also some more info like @patrickkettner requested would be very helpful |
|
BTW: took out some personal infos from your email signature if thats okay with you. |
|
Sure, thank you very much - I simply responded using EMail rather than GIT itself (which was probably a bad idea) |
|
Well, I seem to be a bit lost as I seen to be unable to resolve the conflict properly: the system does not allow me to do so... |
feature-detects/indexeddb.js
Outdated
| addTest('indexeddb', false); | ||
| } else { | ||
| req.onerror = function(event) { | ||
| if (req.error && (req.error.name === 'InvalidStateError' || req.error.name === 'UnknownError')) { |
There was a problem hiding this comment.
that part already got merged via c5ffa86
This reverts commit 94d4116.
|
@rozek I think you can drop the changes in feature-detects/indexeddb.js and take a look at #2336 where changes to that file are also done. The original issue/pr is #2315 Can you take a look at those and see if part of your problem is solved by that (and the xhr iframe issues can stay in this PR on their own)? |
|
Indeed, that fix solves the problems I mentioned as well. I will therefore revert my indexeddb changes completely - hoping, that the other fixes will then go through... |
|
Could you add some infos regarding @patrickkettner questions in the second comment? |
|
hi @rozek sorry for the long pause are you still interested in finishing this PR? If so, could you add some infos as requested in the last comment to this PR? |
rejas
added
the
feedback needed
|
Good morning!
Sorry for the long pause on my side - well, I should definitely complete my PR in order to honour your marvellous work!
But, please, give me 1-2 days to check my local setup and see what I will have to prepare in order to fulfill your request.
With kind regards,
Andreas Rozek Phone: ++49 (7031) 436 5784
Brunnenstraße 30/2 Mobile: ++49 (151) 172 879 18
D-71032 Böblingen EMail: A.Rozek@gmx.de
Germany URL: http://www.Andreas-Rozek.de
… Am 06.10.2019 um 10:54 schrieb Veeck ***@***.***>:
hi @rozek <https://github.com/rozek> sorry for the long pause are you still interested in finishing this PR? If so, could you add some infos as requested in the last comment to this PR?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#2281?email_source=notifications&email_token=AAD5WQV6S2STGGEDDG3JALTQNGRUNA5CNFSM4EMRPQI2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAOEWVY#issuecomment-538725207>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAD5WQTFPGTZTMU4OXBVD4TQNGRUNANCNFSM4EMRPQIQ>.
|
No description provided.