Attempt to use replaceState to validate we can use the History API. #1463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can I get some feedback on this please :) |
| catch (e) { | ||
| return false; | ||
| } | ||
|
|
||
| // Return the regular check | ||
| return (window.history && 'pushState' in window.history); |
There was a problem hiding this comment.
we may as well return true at this point, since we would have had to have used replaceState
|
@stevemckenzie, @patrickkettner bump what do we need to do to get this merged? |
This was referenced Sep 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking if history (pushState) is supported will pass for Firefox Addons with the current implementation but is actually not supported. You cannot tell though until you attempt to actually use the API.
For more info, I originally reported this here: remix-run/react-router#535
Also note the
TODO. Looking for suggestions for that.