Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: oninput detection for IE9-, csshyphens detection for FF and Safari #1428

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

anenviousguest
Copy link
Contributor

oninput detection fix for IE9-

The oninput event detection was not as precise in IE9- as it could be. The oninput test was reporting undefined instead of false, thus making unit tests failing:

    1. Modernizr classes and bools: html classes are looking good

      Test number 163: oninput is correctly false in the classes and objectExpected: false Result: undefined Diff: false undefined
    1. Modernizr classes and bools: Modernizr properties are looking good

      Test number 283: Modernizr.oninput is a boolean value or Boolean object

This was caused by fact that events are created and fired differently in IE9-, see respective code change.

csshyphens detection fix for FF and Safari

  • There was seemingly a typo in CSS property name (text-justification instead of correct text-justify).
  • The hyphenation doesn't take effect unless the lang attribute is explicitly set, for this reason it was erroneously detected as not supported on FF and Safari, whereas it is actually supported.

@anenviousguest anenviousguest changed the title Fix: oninput detection for IE9- Fix: oninput detection for IE9-, csshyphens detection for FF and Safari Sep 24, 2014
@anenviousguest
Copy link
Contributor Author

Hi guys,

I realize you might not have a time yet to review this pull request, but in case you had - is there a chance to merge this? Does it look reasonable to you?

Thanks!

@anenviousguest
Copy link
Contributor Author

Bumping the thread. Any chance to land this?
Thanks!

@rejas
Copy link
Member

rejas commented Jul 6, 2018

hi @anenviousguest sorry for the long delay. if you are still interested, would you mind splittin this PR up and submit only the IE9 stuff? Hypens dectection should go into a seperate PR (the justification already is in a PR, so only the lang part would be needed) Thx

@anenviousguest
Copy link
Contributor Author

hi @rejas, will do, thanks

@rejas
Copy link
Member

rejas commented Jul 20, 2018

so, merged your other PR #2345
this PR needs to get rebased and updated to only include the ie9 stuff if it needs to go foward @anenviousguest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants