fix!: serviceDhcp extraLabels typo #286
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Erik Andersen <etma@etma.dk>
|
Thank you for your contribution. I have some more breaking changes in another branch. I'm thinking of merging your change there and do one new release. On the other hand it would be maybe easier to do some smaller incremental breaks. Not sure how widely adopted this setting is. 🤔 |
MoJo2600
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Fixed a typo in the serviceDhcp.extraLabels implementation.
Benefits
extraLabels for serviceDhcp will work without defining it twice, as serviceDhcp and servicesDhcp.
Possible drawbacks
People who already use the faulty way will not work with this.
Checklist