Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QC: Enhance Intermission+Epilogue Implementation, Add Episode 0 Epilogue. #118

Merged
merged 4 commits into from Mar 10, 2024

Conversation

MotoLegacy
Copy link
Collaborator

Uses data structures to improve implementation for adding new epilogues to specific maps via QuakeC, as well as allows the developer to specify which CD Track to use. Demonstrates usefulness by 1-lining support for LibreQuake's Episode 0, which fixes #117.

Allows easy configuration of Epilogue Texts and CD Track numbers in a
centralized datastructure in client.qc, with a size-agnostic parser
instead of repeated switch statements. Thanks FTEQCC :^)
Uses the new intermission+epilogue data structure to insert a new
epilogue string for LibreQuake's Episode 0 ("The WinQuake Compatible
One"), guarded with __LIBREQUAKE__.
@RandomBrushes RandomBrushes self-assigned this Mar 10, 2024
Copy link
Collaborator

@RandomBrushes RandomBrushes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good IMO. Tested to correctly work on e0m7.

@MissLavender-LQ
Copy link
Owner

looks good to me
image

@MissLavender-LQ MissLavender-LQ merged commit 55588ee into main Mar 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing story-exposition at the end of episode 0
3 participants