Ranges (pegjs/pegjs#30): Add testcases for delimiter support in range…

…s and regenerate parser
Mingun · Feb 19, 2023 · 9ef3d05 · 9ef3d05
1 parent b12d917
commit 9ef3d05
Show file tree

Hide file tree

Showing 9 changed files with 2,363 additions and 274 deletions.
diff --git a/lib/parser.js b/lib/parser.js
diff --git a/test/behavior/generated-parser-behavior.spec.js b/test/behavior/generated-parser-behavior.spec.js
diff --git a/test/types/peg.test-d.ts b/test/types/peg.test-d.ts
@@ -355,6 +355,7 @@ describe("peg.d.ts", () => {
         expectType<peggy.LocationRange>(node.location);
         expectType<peggy.ast.RepeatedBoundary | null>(node.min);
         expectType<peggy.ast.RepeatedBoundary>(node.max);
+        expectType<peggy.ast.Expression | null>(node.delimiter);
         expectType<peggy.ast.Primary>(node.expression);
         visit(node.expression);
       },

diff --git a/test/unit/compiler/passes/generate-bytecode.spec.js b/test/unit/compiler/passes/generate-bytecode.spec.js
diff --git a/test/unit/compiler/passes/inference-match-result.spec.js b/test/unit/compiler/passes/inference-match-result.spec.js
@@ -176,6 +176,170 @@ describe("compiler pass |inferenceMatchResult|", () => {
         });
       });
     });
+
+    describe("with delimiter", () => {
+      describe("with constant boundaries", () => {
+        it("for | .. , delimiter| correctly", () => {
+          expect(pass).to.changeAST("start =  .| .. , .|", { rules: [{ match:  1 }] });
+          expect(pass).to.changeAST("start =  .| .. ,''|", { rules: [{ match:  1 }] });
+          expect(pass).to.changeAST("start =  .| .. ,[]|", { rules: [{ match:  1 }] });
+
+          expect(pass).to.changeAST("start = ''| .. , .|", { rules: [{ match:  1 }] });
+          expect(pass).to.changeAST("start = ''| .. ,''|", { rules: [{ match:  1 }] });
+          expect(pass).to.changeAST("start = ''| .. ,[]|", { rules: [{ match:  1 }] });
+
+          expect(pass).to.changeAST("start = []| .. , .|", { rules: [{ match:  1 }] });
+          expect(pass).to.changeAST("start = []| .. ,''|", { rules: [{ match:  1 }] });
+          expect(pass).to.changeAST("start = []| .. ,[]|", { rules: [{ match:  1 }] });
+        });
+        it("for | ..1, delimiter| correctly", () => {
+          expect(pass).to.changeAST("start =  .| ..1, .|", { rules: [{ match:  1 }] });
+          expect(pass).to.changeAST("start =  .| ..1,''|", { rules: [{ match:  1 }] });
+          expect(pass).to.changeAST("start =  .| ..1,[]|", { rules: [{ match:  1 }] });
+
+          expect(pass).to.changeAST("start = ''| ..1, .|", { rules: [{ match:  1 }] });
+          expect(pass).to.changeAST("start = ''| ..1,''|", { rules: [{ match:  1 }] });
+          expect(pass).to.changeAST("start = ''| ..1,[]|", { rules: [{ match:  1 }] });
+
+          expect(pass).to.changeAST("start = []| ..1, .|", { rules: [{ match:  1 }] });
+          expect(pass).to.changeAST("start = []| ..1,''|", { rules: [{ match:  1 }] });
+          expect(pass).to.changeAST("start = []| ..1,[]|", { rules: [{ match:  1 }] });
+        });
+        it("for | ..3, delimiter| correctly", () => {
+          expect(pass).to.changeAST("start =  .| ..3, .|", { rules: [{ match:  1 }] });
+          expect(pass).to.changeAST("start =  .| ..3,''|", { rules: [{ match:  1 }] });
+          expect(pass).to.changeAST("start =  .| ..3,[]|", { rules: [{ match:  1 }] });
+
+          expect(pass).to.changeAST("start = ''| ..3, .|", { rules: [{ match:  1 }] });
+          expect(pass).to.changeAST("start = ''| ..3,''|", { rules: [{ match:  1 }] });
+          expect(pass).to.changeAST("start = ''| ..3,[]|", { rules: [{ match:  1 }] });
+
+          expect(pass).to.changeAST("start = []| ..3, .|", { rules: [{ match:  1 }] });
+          expect(pass).to.changeAST("start = []| ..3,''|", { rules: [{ match:  1 }] });
+          expect(pass).to.changeAST("start = []| ..3,[]|", { rules: [{ match:  1 }] });
+        });
+        it("for |0.. , delimiter| correctly", () => {
+          expect(pass).to.changeAST("start =  .|0.. , .|", { rules: [{ match:  1 }] });
+          expect(pass).to.changeAST("start =  .|0.. ,''|", { rules: [{ match:  1 }] });
+          expect(pass).to.changeAST("start =  .|0.. ,[]|", { rules: [{ match:  1 }] });
+
+          expect(pass).to.changeAST("start = ''|0.. , .|", { rules: [{ match:  1 }] });
+          expect(pass).to.changeAST("start = ''|0.. ,''|", { rules: [{ match:  1 }] });
+          expect(pass).to.changeAST("start = ''|0.. ,[]|", { rules: [{ match:  1 }] });
+
+          expect(pass).to.changeAST("start = []|0.. , .|", { rules: [{ match:  1 }] });
+          expect(pass).to.changeAST("start = []|0.. ,''|", { rules: [{ match:  1 }] });
+          expect(pass).to.changeAST("start = []|0.. ,[]|", { rules: [{ match:  1 }] });
+        });
+        it("for |1.. , delimiter| correctly", () => {
+          expect(pass).to.changeAST("start =  .|1.. , .|", { rules: [{ match:  0 }] });
+          expect(pass).to.changeAST("start =  .|1.. ,''|", { rules: [{ match:  0 }] });
+          expect(pass).to.changeAST("start =  .|1.. ,[]|", { rules: [{ match:  0 }] });
+
+          expect(pass).to.changeAST("start = ''|1.. , .|", { rules: [{ match:  1 }] });
+          expect(pass).to.changeAST("start = ''|1.. ,''|", { rules: [{ match:  1 }] });
+          expect(pass).to.changeAST("start = ''|1.. ,[]|", { rules: [{ match:  1 }] });
+
+          expect(pass).to.changeAST("start = []|1.. , .|", { rules: [{ match: -1 }] });
+          expect(pass).to.changeAST("start = []|1.. ,''|", { rules: [{ match: -1 }] });
+          expect(pass).to.changeAST("start = []|1.. ,[]|", { rules: [{ match: -1 }] });
+        });
+        it("for |2.. , delimiter| correctly", () => {
+          expect(pass).to.changeAST("start =  .|2.. , .|", { rules: [{ match:  0 }] });
+          expect(pass).to.changeAST("start =  .|2.. ,''|", { rules: [{ match:  0 }] });
+          expect(pass).to.changeAST("start =  .|2.. ,[]|", { rules: [{ match: -1 }] });
+
+          expect(pass).to.changeAST("start = ''|2.. , .|", { rules: [{ match:  0 }] });
+          expect(pass).to.changeAST("start = ''|2.. ,''|", { rules: [{ match:  1 }] });
+          expect(pass).to.changeAST("start = ''|2.. ,[]|", { rules: [{ match: -1 }] });
+
+          expect(pass).to.changeAST("start = []|2.. , .|", { rules: [{ match: -1 }] });
+          expect(pass).to.changeAST("start = []|2.. ,''|", { rules: [{ match: -1 }] });
+          expect(pass).to.changeAST("start = []|2.. ,[]|", { rules: [{ match: -1 }] });
+        });
+        it("for |2..3, delimiter| correctly", () => {
+          expect(pass).to.changeAST("start =  .|2..3, .|", { rules: [{ match:  0 }] });
+          expect(pass).to.changeAST("start =  .|2..3,''|", { rules: [{ match:  0 }] });
+          expect(pass).to.changeAST("start =  .|2..3,[]|", { rules: [{ match: -1 }] });
+
+          expect(pass).to.changeAST("start = ''|2..3, .|", { rules: [{ match:  0 }] });
+          expect(pass).to.changeAST("start = ''|2..3,''|", { rules: [{ match:  1 }] });
+          expect(pass).to.changeAST("start = ''|2..3,[]|", { rules: [{ match: -1 }] });
+
+          expect(pass).to.changeAST("start = []|2..3, .|", { rules: [{ match: -1 }] });
+          expect(pass).to.changeAST("start = []|2..3,''|", { rules: [{ match: -1 }] });
+          expect(pass).to.changeAST("start = []|2..3,[]|", { rules: [{ match: -1 }] });
+        });
+        it("for | 42 , delimiter| correctly", () => {
+          expect(pass).to.changeAST("start =  .| 42 , .|", { rules: [{ match:  0 }] });
+          expect(pass).to.changeAST("start =  .| 42 ,''|", { rules: [{ match:  0 }] });
+          expect(pass).to.changeAST("start =  .| 42 ,[]|", { rules: [{ match: -1 }] });
+
+          expect(pass).to.changeAST("start = ''| 42 , .|", { rules: [{ match:  0 }] });
+          expect(pass).to.changeAST("start = ''| 42 ,''|", { rules: [{ match:  1 }] });
+          expect(pass).to.changeAST("start = ''| 42 ,[]|", { rules: [{ match: -1 }] });
+
+          expect(pass).to.changeAST("start = []| 42 , .|", { rules: [{ match: -1 }] });
+          expect(pass).to.changeAST("start = []| 42 ,''|", { rules: [{ match: -1 }] });
+          expect(pass).to.changeAST("start = []| 42 ,[]|", { rules: [{ match: -1 }] });
+        });
+      });
+
+      describe("with variable boundaries", () => {
+        it("for |   ..max, delimiter| correctly", () => {
+          expect(pass).to.changeAST("start =  .|   ..max, .|", { rules: [{ match: 0 }] });
+          expect(pass).to.changeAST("start =  .|   ..max,''|", { rules: [{ match: 0 }] });
+          expect(pass).to.changeAST("start =  .|   ..max,[]|", { rules: [{ match: 0 }] });
+
+          expect(pass).to.changeAST("start = ''|   ..max, .|", { rules: [{ match: 0 }] });
+          expect(pass).to.changeAST("start = ''|   ..max,''|", { rules: [{ match: 0 }] });
+          expect(pass).to.changeAST("start = ''|   ..max,[]|", { rules: [{ match: 0 }] });
+
+          expect(pass).to.changeAST("start = []|   ..max, .|", { rules: [{ match: 0 }] });
+          expect(pass).to.changeAST("start = []|   ..max,''|", { rules: [{ match: 0 }] });
+          expect(pass).to.changeAST("start = []|   ..max,[]|", { rules: [{ match: 0 }] });
+        });
+        it("for |min..   , delimiter| correctly", () => {
+          expect(pass).to.changeAST("start =  .|min..   , .|", { rules: [{ match: 0 }] });
+          expect(pass).to.changeAST("start =  .|min..   ,''|", { rules: [{ match: 0 }] });
+          expect(pass).to.changeAST("start =  .|min..   ,[]|", { rules: [{ match: 0 }] });
+
+          expect(pass).to.changeAST("start = ''|min..   , .|", { rules: [{ match: 0 }] });
+          expect(pass).to.changeAST("start = ''|min..   ,''|", { rules: [{ match: 0 }] });
+          expect(pass).to.changeAST("start = ''|min..   ,[]|", { rules: [{ match: 0 }] });
+
+          expect(pass).to.changeAST("start = []|min..   , .|", { rules: [{ match: 0 }] });
+          expect(pass).to.changeAST("start = []|min..   ,''|", { rules: [{ match: 0 }] });
+          expect(pass).to.changeAST("start = []|min..   ,[]|", { rules: [{ match: 0 }] });
+        });
+        it("for |min..max, delimiter| correctly", () => {
+          expect(pass).to.changeAST("start =  .|min..max, .|", { rules: [{ match: 0 }] });
+          expect(pass).to.changeAST("start =  .|min..max,''|", { rules: [{ match: 0 }] });
+          expect(pass).to.changeAST("start =  .|min..max,[]|", { rules: [{ match: 0 }] });
+
+          expect(pass).to.changeAST("start = ''|min..max, .|", { rules: [{ match: 0 }] });
+          expect(pass).to.changeAST("start = ''|min..max,''|", { rules: [{ match: 0 }] });
+          expect(pass).to.changeAST("start = ''|min..max,[]|", { rules: [{ match: 0 }] });
+
+          expect(pass).to.changeAST("start = []|min..max, .|", { rules: [{ match: 0 }] });
+          expect(pass).to.changeAST("start = []|min..max,''|", { rules: [{ match: 0 }] });
+          expect(pass).to.changeAST("start = []|min..max,[]|", { rules: [{ match: 0 }] });
+        });
+        it("for | exact  , delimiter| correctly", () => {
+          expect(pass).to.changeAST("start =  .| exact  , .|", { rules: [{ match: 0 }] });
+          expect(pass).to.changeAST("start =  .| exact  ,''|", { rules: [{ match: 0 }] });
+          expect(pass).to.changeAST("start =  .| exact  ,[]|", { rules: [{ match: 0 }] });
+
+          expect(pass).to.changeAST("start = ''| exact  , .|", { rules: [{ match: 0 }] });
+          expect(pass).to.changeAST("start = ''| exact  ,''|", { rules: [{ match: 0 }] });
+          expect(pass).to.changeAST("start = ''| exact  ,[]|", { rules: [{ match: 0 }] });
+
+          expect(pass).to.changeAST("start = []| exact  , .|", { rules: [{ match: 0 }] });
+          expect(pass).to.changeAST("start = []| exact  ,''|", { rules: [{ match: 0 }] });
+          expect(pass).to.changeAST("start = []| exact  ,[]|", { rules: [{ match: 0 }] });
+        });
+      });
+    });
   });
 
   it("calculate |match| property for |group| correctly", () => {

diff --git a/test/unit/compiler/passes/report-duplicate-labels.spec.js b/test/unit/compiler/passes/report-duplicate-labels.spec.js
@@ -41,6 +41,7 @@ describe("compiler pass |reportDuplicateLabels|", () => {
       expect(pass).to.not.reportError("start = (a:'a')* a:'a'");
       expect(pass).to.not.reportError("start = (a:'a')+ a:'a'");
       expect(pass).to.not.reportError("start = (a:'a')|2..3| a:'a'");
+      expect(pass).to.not.reportError("start = 'a'|2..3, a:'a'| a:'a'");
       expect(pass).to.not.reportError("start = (a:'a') a:'a'");
     });
   });

diff --git a/test/unit/compiler/passes/report-infinite-recursion.spec.js b/test/unit/compiler/passes/report-infinite-recursion.spec.js
@@ -136,4 +136,26 @@ describe("compiler pass |reportInfiniteRecursion|", () => {
       expect(pass).to.not.reportError("start = . start");
     });
   });
+
+  describe("in repeated with delimiter", () => {
+    it("doesn't report left recursion for delimiter if expression not match empty string", () => {
+      expect(pass).to.not.reportError("start = 'a'| .. , start|");
+      expect(pass).to.not.reportError("start = 'a'|0.. , start|");
+      expect(pass).to.not.reportError("start = 'a'|1.. , start|");
+      expect(pass).to.not.reportError("start = 'a'|2.. , start|");
+      expect(pass).to.not.reportError("start = 'a'| ..3, start|");
+      expect(pass).to.not.reportError("start = 'a'|2..3, start|");
+      expect(pass).to.not.reportError("start = 'a'| 42 , start|");
+    });
+
+    it("reports left recursion for delimiter if expression match empty string", () => {
+      expect(pass).to.reportError("start = ''| .. , start|");
+      expect(pass).to.reportError("start = ''|0.. , start|");
+      expect(pass).to.reportError("start = ''|1.. , start|");
+      expect(pass).to.reportError("start = ''|2.. , start|");
+      expect(pass).to.reportError("start = ''| ..3, start|");
+      expect(pass).to.reportError("start = ''|2..3, start|");
+      expect(pass).to.reportError("start = ''| 42 , start|");
+    });
+  });
 });
diff --git a/test/unit/compiler/passes/report-infinite-repetition.spec.js b/test/unit/compiler/passes/report-infinite-repetition.spec.js
@@ -88,6 +88,85 @@ describe("compiler pass |reportInfiniteRepetition|", () => {
         expect(pass).to.not.reportError("start = ('')|len|");
       });
     });
+
+    describe("with empty delimiter", () => {
+      it("with constant boundaries", () => {
+        expect(pass).to.reportError("start = ('')| .., ''|", {
+          message:  "Possible infinite loop when parsing (unbounded range repetition used with an expression that may not consume any input)",
+          location: {
+            source: undefined,
+            start: { offset:  8, line: 1, column:  9 },
+            end:   { offset: 21, line: 1, column: 22 },
+          },
+        });
+        expect(pass).to.reportError("start = ('')|0.., ''|", {
+          message:  "Possible infinite loop when parsing (unbounded range repetition used with an expression that may not consume any input)",
+          location: {
+            source: undefined,
+            start: { offset:  8, line: 1, column:  9 },
+            end:   { offset: 21, line: 1, column: 22 },
+          },
+        });
+        expect(pass).to.reportError("start = ('')|1.., ''|", {
+          message:  "Possible infinite loop when parsing (unbounded range repetition used with an expression that may not consume any input)",
+          location: {
+            source: undefined,
+            start: { offset:  8, line: 1, column:  9 },
+            end:   { offset: 21, line: 1, column: 22 },
+          },
+        });
+        expect(pass).to.reportError("start = ('')|2.., ''|", {
+          message:  "Possible infinite loop when parsing (unbounded range repetition used with an expression that may not consume any input)",
+          location: {
+            source: undefined,
+            start: { offset:  8, line: 1, column:  9 },
+            end:   { offset: 21, line: 1, column: 22 },
+          },
+        });
+
+        expect(pass).to.not.reportError("start = ('')| ..1, ''|");
+        expect(pass).to.not.reportError("start = ('')| ..3, ''|");
+        expect(pass).to.not.reportError("start = ('')|2..3, ''|");
+        expect(pass).to.not.reportError("start = ('')| 42 , ''|");
+      });
+
+      it("with variable boundaries", () => {
+        expect(pass).to.reportError("start = ('')|len.., ''|", {
+          message:  "Possible infinite loop when parsing (unbounded range repetition used with an expression that may not consume any input)",
+          location: {
+            source: undefined,
+            start: { offset:  8, line: 1, column:  9 },
+            end:   { offset: 23, line: 1, column: 24 },
+          },
+        });
+
+        expect(pass).to.not.reportError("start = ('')|..len, ''|");
+        expect(pass).to.not.reportError("start = ('')|len1..len2, ''|");
+        expect(pass).to.not.reportError("start = ('')|len, ''|");
+      });
+    });
+
+    describe("with non-empty delimiter", () => {
+      it("with constant boundaries", () => {
+        expect(pass).to.not.reportError("start = ('')| .., 'a'|");
+        expect(pass).to.not.reportError("start = ('')|0.., 'a'|");
+        expect(pass).to.not.reportError("start = ('')|1.., 'a'|");
+        expect(pass).to.not.reportError("start = ('')|2.., 'a'|");
+
+        expect(pass).to.not.reportError("start = ('')| ..1, 'a'|");
+        expect(pass).to.not.reportError("start = ('')| ..3, 'a'|");
+        expect(pass).to.not.reportError("start = ('')|2..3, 'a'|");
+        expect(pass).to.not.reportError("start = ('')| 42 , 'a'|");
+      });
+
+      it("with variable boundaries", () => {
+        expect(pass).to.not.reportError("start = ('')|len.., 'a'|");
+
+        expect(pass).to.not.reportError("start = ('')|..len, 'a'|");
+        expect(pass).to.not.reportError("start = ('')|len1..len2, 'a'|");
+        expect(pass).to.not.reportError("start = ('')|len, 'a'|");
+      });
+    });
   });
 
   it("computes expressions that always consume input on success correctly", () => {