feat: LivingEntity fire overhaul #2122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
DeidaraMC
commented
May 1, 2024
DeidaraMC
commented
- Fire duration uses ticks
- Setting fire through the entity meta will not expire it immediately
- Renamed EntityFireEvent > EntitySetFireEvent
- Added an EntityFireExtinguishEvent for when fire is extinguished
- Removed fire damage period, it was was not being used anyway
- Fire related unit tests
|
it feels like we should not lose the behavior of an event while the player is on fire. That seems like the most common case (like ticking health down) |
mworzala
approved these changes
May 4, 2024
mworzala
pushed a commit
that referenced
this pull request
May 27, 2024
* feat: LivingEntity fire overhaul * chore: missed method change
mworzala
pushed a commit
that referenced
this pull request
Jun 2, 2024
* feat: LivingEntity fire overhaul * chore: missed method change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.