feat: setTimeUpdate transition from duration to ticks, renamed to avoid ambiguation with setTimeRate #2067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mworzala
approved these changes
Mar 29, 2024
…d ambiguation with setTimeRate
mworzala
force-pushed
the
instance-time-update
branch
from
71e6d73
to
4fb9499
Compare
mworzala
pushed a commit
that referenced
this pull request
May 27, 2024
…d ambiguation with setTimeRate (#2067)
mworzala
pushed a commit
that referenced
this pull request
Jun 2, 2024
…d ambiguation with setTimeRate (#2067)
mworzala
pushed a commit
that referenced
this pull request
Jun 7, 2024
…d ambiguation with setTimeRate (#2067)
mworzala
pushed a commit
that referenced
this pull request
Jun 8, 2024
…d ambiguation with setTimeRate (#2067)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transitioned setTimeUpdate from use of duration to ticks
Additionally taking this opportunity to rename Instance#get/setTimeUpdate to get/setTimeSynchronizationTicks for parity with Entity#get/setTimeSynchronizationTicks and to avoid confusion between timeRate and timeUpdate