fix: damaged entities not playing their animation, animation type for source-less damage #2063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mworzala
reviewed
Mar 29, 2024
| if (animation != EntityDamageEvent.AnimationType.NONE) { | ||
| int entitySourceId = damage.getSource() == null ? 0 : damage.getSource().getEntityId(); | ||
| boolean withSource = animation == EntityDamageEvent.AnimationType.WITH_SOURCE; | ||
| DamageEventPacket damageEventPacket = withSource ? new DamageEventPacket(getEntityId(), damage.getType().id(), entitySourceId, entitySourceId, damage.getSourcePosition()) : |
There was a problem hiding this comment.
use an if statement please, also some tests would be great
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to send a DamageEventPacket rather than an EntityAnimationPacket.
Additionally, an AnimationType needed to be added to let the damage animation be played in a similar style to pre-1.20 (damage tilt remains constant regardless of source)
fix for #2061