Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Permissions rework #2023

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Permissions rework #2023

wants to merge 6 commits into from

Conversation

MelonHell
Copy link
Contributor

resolves #2021

LooFifteen
LooFifteen approved these changes Mar 14, 2024
View reviewed changes
Copy link

@LooFifteen LooFifteen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MelonHell
Copy link
Contributor Author

Why do entities need permissions? It seems to me that they are only needed by CommandSender

@MelonHell
Copy link
Contributor Author

TODO rename Permissions back to PermissionHandler and add a setter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LooFifteen LooFifteen LooFifteen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rework the permission system
2 participants
@MelonHell @LooFifteen