Add link when using iframes to have iframes without using the grafana-renderer and still have links to Grafana #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi Carsten We have the problem, that the grafana-renderer is very slow and uses a lot resources. Is much faster, to use iframes to embed graphs in icingaweb2. Further you then have tooltips in the graphs. The downside is, that you do no longer have links to grafana to open a dashboard from icingaweb2. So I extended Grapher.php to add a link above the grafana panels embedded as iframes into icingaweb2. With this, you have much faster rendering of the graphs in the iframes and you still can click on a link '=> see in Grafana' to open the panel in Grafana. I did the according changes to GeneralConfigForm.php to be able to interactively do the config for the grafana-module too.
I did the according changes to GeneralConfigForm.php to be able to interactively do the config for the grafana-module too. Maybe someone can enhance the php?
Update Grapher.php
|
I just have seen, that there is a different behaviour regarding the width of the graphs depending on debug mode is on or off. |
Make hight configurabel for iframes.
|
I did some enhancements to my changes in Grapher.php and set the with of iframes to 100%, so the width is set by the width of the browser window. |
|
I like this, and I like this alot. Thank you for your work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Carsten
We have the problem, that the grafana-renderer is very slow and uses a lot resources. Is much faster, to use iframes to embed graphs in icingaweb2. Further you then have tooltips in the graphs.
The downside is, that you do no longer have links to grafana to open a dashboard from icingaweb2.
So I extended Grapher.php to add a link above the grafana panels embedded as iframes into icingaweb2. With this, you have much faster rendering of the graphs in the iframes and you still can click on a link '=> see in Grafana' to open the panel in Grafana.
I did the according changes to GeneralConfigForm.php to be able to interactively do the config for the grafana-module too.