Add ability to robots to obtain nearby experience orbs #3702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like the cause of the crash is two missing configuration entries, something the past patch missed. |
zeng-github01
changed the title
|
@asiekierka After investigation, Minecraft does not fire any events when a transaction is triggered. Only some experience orbs will be spawned This problem cannot be fixed through ordinary solutions in the current version. The only solution might be to add a custom event trigger to “useRecipe” through a mixin or ASM A feasible method is to imitate this submission and add a logic to absorb experience balls in Trade.scala when the complateTrade judgment is completed, but there may be a lag. Or just like this PR, giving players the power to customize |
|
@asiekierka The patch has been tested and meets the expected results |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporary fix #3289
Existing bug: The format of settings.conf is wrong and cannot be parsed correctly, which will cause a crash.
A temporary fix has been made to this bug. Looks like a past patch oversight caused the crash, so it needs to be reviewed